Skip to content

[Vlans]: Extract VLAN_MEMBER_TABLE from VLAN_TABLE#229

Merged
pavel-shirshov merged 3 commits intosonic-net:masterfrom
pavel-shirshov:pavelsh/vlan_member
Jun 1, 2017
Merged

[Vlans]: Extract VLAN_MEMBER_TABLE from VLAN_TABLE#229
pavel-shirshov merged 3 commits intosonic-net:masterfrom
pavel-shirshov:pavelsh/vlan_member

Conversation

@pavel-shirshov
Copy link
Contributor

127.0.0.1:6379> keys VLAN*

  1. "VLAN_MEMBER_TABLE:Vlan2:Ethernet7"
  2. "VLAN_MEMBER_TABLE:Vlan2:Ethernet10"
  3. "VLAN_MEMBER_TABLE:Vlan2:Ethernet25"
  4. "VLAN_MEMBER_TABLE:Vlan2:Ethernet15"
  5. "VLAN_MEMBER_TABLE:Vlan2:Ethernet39"
  6. "VLAN_MEMBER_TABLE:Vlan2:Ethernet58"
  7. "VLAN_MEMBER_TABLE:Vlan2:Ethernet37"
  8. "VLAN_MEMBER_TABLE:Vlan2:Ethernet42"
  9. "VLAN_MEMBER_TABLE:Vlan2:Ethernet9"
  10. "VLAN_MEMBER_TABLE:Vlan2:Ethernet55"
  11. "VLAN_MEMBER_TABLE:Vlan2:Ethernet22"
  12. "VLAN_MEMBER_TABLE:Vlan2:Ethernet53"
  13. "VLAN_MEMBER_TABLE:Vlan2:Ethernet40"
  14. "VLAN_MEMBER_TABLE:Vlan2:Ethernet12"
  15. "VLAN_MEMBER_TABLE:Vlan2:Ethernet6"
  16. "VLAN_MEMBER_TABLE:Vlan2:Ethernet29"
  17. "VLAN_MEMBER_TABLE:Vlan2:Ethernet13"
  18. "VLAN_MEMBER_TABLE:Vlan2:Ethernet27"
  19. "VLAN_MEMBER_TABLE:Vlan2:Ethernet48"
  20. "VLAN_MEMBER_TABLE:Vlan2:Ethernet38"
  21. "VLAN_MEMBER_TABLE:Vlan2:Ethernet26"
  22. "VLAN_MEMBER_TABLE:Vlan2:Ethernet32"
  23. "VLAN_MEMBER_TABLE:Vlan2:Ethernet23"
  24. "VLAN_MEMBER_TABLE:Vlan2:Ethernet41"
  25. "VLAN_MEMBER_TABLE:Vlan2:Ethernet28"
  26. "VLAN_MEMBER_TABLE:Vlan2:Ethernet11"
  27. "VLAN_MEMBER_TABLE:Vlan2:Ethernet36"
  28. "VLAN_MEMBER_TABLE:Vlan2:Ethernet57"
  29. "VLAN_MEMBER_TABLE:Vlan2:Ethernet30"
  30. "VLAN_MEMBER_TABLE:Vlan2:Ethernet8"
  31. "VLAN_MEMBER_TABLE:Vlan2:Ethernet14"
  32. "VLAN_MEMBER_TABLE:Vlan2:Ethernet31"
  33. "VLAN_MEMBER_TABLE:Vlan2:Ethernet54"
  34. "VLAN_TABLE:Vlan2"
  35. "VLAN_MEMBER_TABLE:Vlan2:Ethernet24"
  36. "VLAN_MEMBER_TABLE:Vlan2:Ethernet56"
  37. "VLAN_MEMBER_TABLE:Vlan2:Ethernet52"

mtu = 1*4DIGIT ; MTU for the IP interface of the VLAN

key = VLAN_TABLE:vlanid:ifname ; physical port member of VLAN
key = VLAN_MEMBER_TABLE:vlanid:ifname ; physical port member of VLAN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a separate table here?

For the VLAN_MEMBER_TABLE, tagging_mode is its attribute.

For the VLAN_TABLE, it does not need to have tagging_mode as an attribute.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current orchagent code, it does not read this tagging mode. You need this function, I think you can do that in another separate CR.

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seperate the VLAN_MEMBER_TABLE in the swss-schema.md

@pavel-shirshov pavel-shirshov merged commit 682d7cb into sonic-net:master Jun 1, 2017
@pavel-shirshov pavel-shirshov deleted the pavelsh/vlan_member branch June 1, 2017 17:53
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
* [syncd][PFC WD]: Add support for SAI PFC storm notification

This commit implements native support for
SAI_SWITCH_ATTRIBUTE_QUEUE_PFC_DEADLOCK_NOTIFY.
Calling lua scripts is moved from orchagent to syncd, which uses native
notification by a SW watchdog as well.

Signed-off-by: marian-pritsak <[email protected]>

* [syncd_pfcwatchdog]: Add plugin subscription

Signed-off-by: marian-pritsak <[email protected]>

* [syncd]: Remove native notidications

Signed-off-by: marian-pritsak <[email protected]>

* [syncd.cpp]: Fix typo

Signed-off-by: marian-pritsak <[email protected]>

* Address comments

Signed-off-by: marian-pritsak <[email protected]>
lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023
…SD info (sonic-net#229)

The problem:
    The current SSD health API uses a SSD vendor specific utility to retrieve
    values for overall SSD health and internal SSD temperature. These utilities
    are typically made available only in binary form and are not always
    available for all platform architectures (amd64, arm64, armhf, etc.)
    Vendor licensing agreements can prevent the inclusion of utility source
    code in the Sonic build.

The solution presented here is to retrieve SSD health and temperature values
from the generic SSD info retrieved via the open-source smartmontools utility
(smartctl). These values can be overwritten with values retrieved using a
vendor specific utility when available. smartmontools is already included in
the Sonic source tree and is being built for all platform architectures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants